Skip to content
This repository has been archived by the owner on Feb 18, 2023. It is now read-only.

Bump 3rd party dependencies #110

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Conversation

lucasponce
Copy link
Contributor

I've added the bump of the 3rd party dependencies into the package.json.

Storybook seems to work correctly but I didn't test this within Kiali, it would require other check to see if it doesn't contain any side effect.

@lucasponce
Copy link
Contributor Author

@hhovsepy @skondkar I know it's a component not the whole Kiali UI, would you mind to smoke test checking for regressions on this ? Thanks

Copy link
Member

@israel-hdez israel-hdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It builds OK.

These are sub-dependencies of react-scripts and terser-webpack-plugin. These are dev-dependencies, so I think it should be OK from Kiali.

@hhovsepy
Copy link

Smoke tested the metrics.

@lucasponce lucasponce merged commit 07c6737 into kiali:master Aug 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants