Skip to content
This repository has been archived by the owner on Feb 18, 2023. It is now read-only.

Introduce collapsible blocks for charts #92

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Introduce collapsible blocks for charts #92

merged 1 commit into from
Jun 23, 2020

Conversation

jotak
Copy link
Collaborator

@jotak jotak commented Jun 19, 2020 •
edited

  • Empty data starts collapsed
  • New StartCollapsed field in charts model & CRD
  • Use patternfly's EmptyState
  • Add story

Fixes kiali/kiali#2614

@jotak
Introduce collapsible blocks for charts
f229cf4 
- Empty data starts collapsed
- New StartCollapsed field in charts model & CRD
- Use patternfly's EmptyState
- Add story

Part-of kiali/kiali#2614
@jotak
Copy link
Collaborator Author

jotak commented Jun 19, 2020

Now charts from k-charted are embedded in collapsible blocks, see for instance the storybook dashboard:

Capture d’écran de 2020-06-19 10-16-19

Charts with no data will start collapsed. Charts with data, or the ones showing errors, start expanded by default, unless they are configured to not do so (per CRD / props)

@jotak jotak added this to In Review in Sprint 41 Jun 19, 2020
@aljesusg
Copy link
Contributor

aljesusg commented Jun 23, 2020 •
edited by jotak

MMM I am thinking about to add next to the title the related icon with a tooltip (no data/error) to let the user know that there is not data or an error without expand the chart.

img1

img2

aljesusg
aljesusg approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@aljesusg aljesusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM only the comment about improve the title

@jotak
Copy link
Collaborator Author

jotak commented Jun 23, 2020

MMM I am thinking about to add next to the title the related icon with a tooltip (no data/error) to let the user know that there is not data or an error without expand the chart.

Good idea i'll try that

@jotak
Copy link
Collaborator Author

jotak commented Jun 23, 2020

@aljesusg it doesn't work :-(
Patternfly's Expandable, which I use here, requires a string only as title. Else it would display [object Object]:

Capture d’écran de 2020-06-23 11-28-41

@aljesusg
Copy link
Contributor

@aljesusg it doesn't work :-(
Patternfly's Expandable, which I use here, requires a string only as title. Else it would display [object Object]:

Capture d’écran de 2020-06-23 11-28-41

Yes...it seems that we can't ...let me open this in patternfly, go ahead with this . Thanks @jotak

@jotak jotak merged commit 230f943 into kiali:master Jun 23, 2020
Sprint 41 automation moved this from In Review to Done Jun 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aljesusg aljesusg aljesusg approved these changes

@hhovsepy hhovsepy Awaiting requested review from hhovsepy

@mtho11 mtho11 Awaiting requested review from mtho11

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Sprint 41
  
Done
Milestone
No milestone
2 participants
@jotak @aljesusg