KIALI-1766 - Using Swagger to generate Kiali Client

[gbaufake]

Using Swagger to auto-generate the Files and including Requests for some Metadata on Requests

[gbaufake]

This Pull Request included 33 API Tests (one for each REST API available at swagger)

[mattmahoneyrh]

Consider adding handling/retries for connection errors that appear to be transient and random, during E2E test runs.

[burmanm]

Shouldn't the E2E test take care of that? If there's a connection error, you'll get a Python error which can be easily catched.

I don't know why this copy of client removed the error handling, but this is the part from Hawkular's codebase:

        elif isinstance(e, URLError):
            # Cast to HawkularMetricsConnectionError
            ee = HawkularConnectionError(e)
            ee.msg = "Error, could not send event(s) to the Hawkular Metrics: " + str(e.reason)
            raise ee

Those are the cases when there's a connection timeout etc.

[gbaufake]

Shouldn't the E2E test take care of that? If there's a connection error, you'll get a Python error which can be easily catched.

I don't know why this copy of client removed the error handling, but this is the part from Hawkular's codebase:

        elif isinstance(e, URLError):
            # Cast to HawkularMetricsConnectionError
            ee = HawkularConnectionError(e)
            ee.msg = "Error, could not send event(s) to the Hawkular Metrics: " + str(e.reason)
            raise ee

Those are the cases when there's a connection timeout etc.

I have removed on this PR because we wanted to know more than error message... eg: request, url and other metadata that might be useful to discover if the test failed because of an environmental issue or some problem on API.

Maybe I could implement an error handling that can have another.
Any suggestion on this @burmanm?

[burmanm]

Why would those casts remove the access to that information? They were just using inheritance, class HawkularConnectionError(URLError):. The idea was to make the client hide certain implementation details in everyday use.

Point is, I think retry should be in the testing code - not the client code. Otherwise the client's retry might hide something that should be catched by tests. The test should determine which failures are acceptable, not the client. That's my opinion.

[gbaufake]

This PR depends on kiali/kiali#693 and kiali/kiali#698