Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for the new HPA v2 (v2beta2 has been deprecated and removed in newer k8s #536

Merged
merged 1 commit into from May 16, 2022

Conversation

jmazzitelli
Copy link
Contributor

@jmazzitelli jmazzitelli commented May 12, 2022

part of: kiali/kiali#5022

We are moving to a default of HPA v2.

If you still require v2beta2 (i.e. if you are on an older k8s version), you will now be required to update your Kial CR to explicitly define the HPA api_version via:

deployment:
  hpa:
    api_version: "autoscaling/v2beta2"

@jmazzitelli jmazzitelli added this to In Review in Sprint 73 (v1.51) via automation May 12, 2022
@jmazzitelli jmazzitelli self-assigned this May 12, 2022
@jmazzitelli
Copy link
Contributor Author

This needs testing. I'll do that shortly.
Also this may need to be backported. Still need to look into that.

@jmazzitelli
Copy link
Contributor Author

testing complete - molecule test shows it working:

     affinity-tolerations-resources-test... success [4m 27s]

@jmazzitelli jmazzitelli marked this pull request as ready for review May 12, 2022 14:17
Copy link
Contributor

@leandroberetta leandroberetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jmazzitelli jmazzitelli merged commit 128210e into kiali:master May 16, 2022
Sprint 73 (v1.51) automation moved this from In Review to Done May 16, 2022
@jmazzitelli jmazzitelli deleted the 5022-hpa-update branch May 16, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2 participants