Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename kiali_vars to kiali_vars_remove so it is unique to the remove role #652

Merged
merged 1 commit into from May 25, 2023

Conversation

jmazzitelli
Copy link
Contributor

@jmazzitelli
Copy link
Contributor Author

The basic test to see this work is to create a Kiali CR with spec.version set to X. And then after Kiali is deployed, change the Kiali CR's spec.version to Y (where X and Y are valid spec.versions like default, v1.65, etc). This should no longer fail. The test will update the Kiali CR 3 times to see that we can move spec.version from default to v1.65 to v1.57 then back to default. This is necessary to test the changes made in this PR.

Detailed test procedures:

  1. Install a kubernetes cluster (doesn't matter which - OpenShift, minikube, whatever - I will be using minikube in these test instructions).
  2. Install Istio
  3. Pull this operator PR into your dev environment
  4. Build and push the server and operator container images to your cluster: make -e CLUSTER_TYPE=minikube build build-ui cluster-push
  5. Deploy the operator to the cluster: make -e CLUSTER_TYPE=minikube operator-create
  6. Ensure the operator is running now: kubectl get pods -n kiali-operator

At this point, we are ready to start creating and modifying the Kiali CR - we will create an initial CR and then modify it three times, changing the spec.version each time. After each time the Kiali CR is touched, wait for the Kiali server pod to start (in a separate window, run kubectl get pods -n istio-system -l app=kiali -w and you'll see the server pod come up and down as the operator processes the CR each time). If you see the server pod running after the operator finishes reconciling the CR, the test is passing. You can also check the operator logs - you should no longer see the errors that were happening before.

  1. Create a Kiali CR with spec.version of default using make: make -e CLUSTER_TYPE=minikube -e KIALI_CR_SPEC_VERSION=default kiali-create
  2. Update the Kiali CR with spec.version of v1.65 using make: make -e CLUSTER_TYPE=minikube -e KIALI_CR_SPEC_VERSION=v1.65 kiali-create
  3. Update the Kiali CR with spec.version of v1.57 using make: make -e CLUSTER_TYPE=minikube -e KIALI_CR_SPEC_VERSION=v1.57 kiali-create
  4. Update the Kiali CR with spec.version of default using make: make -e CLUSTER_TYPE=minikube -e KIALI_CR_SPEC_VERSION=default kiali-create

@jmazzitelli jmazzitelli marked this pull request as ready for review May 25, 2023 00:54
@jmazzitelli jmazzitelli added the do not merge Do not merge this PR yet label May 25, 2023
@jmazzitelli
Copy link
Contributor Author

jmazzitelli commented May 25, 2023

Do not merge this until this PR is merged: #654
I found an odd conflict in my PR here that ultimately uncovered this problem. I want that fixed by merging that PR, then I need to rebase this PR on master (which will likely result in a similar conflict that I will have to reconcile).

@jmazzitelli jmazzitelli removed the do not merge Do not merge this PR yet label May 25, 2023
@jmazzitelli jmazzitelli force-pushed the 6199-remove-kiali-vars-rename branch from 0c8325e to 3083c42 Compare May 25, 2023 13:06
@jmazzitelli
Copy link
Contributor Author

OK.. the v1.65 role has been fixed in master and this PR has been rebased with conflicts resolved. This is ready for review/approval/merge.

@jshaughn jshaughn self-requested a review May 25, 2023 17:12
@jmazzitelli jmazzitelli force-pushed the 6199-remove-kiali-vars-rename branch from 3083c42 to f9a0838 Compare May 25, 2023 17:17
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All test steps passed, changed kiali spec version 3 times, operator reconciled with no errors each time and kiali pod restarted without issues.

@jmazzitelli jmazzitelli merged commit 33e6f79 into kiali:master May 25, 2023
1 check passed
@jmazzitelli jmazzitelli deleted the 6199-remove-kiali-vars-rename branch May 25, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2 participants