be able to tell what dashboards to create

[jmazzitelli]

fixes: kiali/kiali#2989
Users probably won't want all of them, and they just cause the Kiali CR processing to be slower than need be.
The default is backward compat to previous behavior (all monitoring dashboard resources are created) but you now have the ability to not install those you do not want. e.g., in the Kiali CR:

deployment:
  custom_dashboards:
    includes: ['go*', 'kiali*']

This will install the Go and Kiali monitoring dashboards but no others.

deployment:
  custom_dashboards:
    includes: ['vertx*']
    excludes: ['vertx-server*']

This will install all the vertx dashboards except the server.

[jmazzitelli]

You would think the default excludes can be an empty list but you will notice the default is a list with one empty string [''] - this is because if it is empty, a bug in ansible find task will exclude everything.

[jmazzitelli]

This PR includes a molecule test that shows this working.

[jmazzitelli]

@jotak what are we calling the "monitoring dashboards" today? Is it still "monitoring dashboards"?

This PR introduces a new section in the Kiali CR under deployments called dashboards - I want to make sure I name that new section correctly. I was thinking monitoring_dashboards but I do not know if that is the official name for these things.

For details of this new section, see the kiali_cr.yaml comments.

[jotak]

@jmazzitelli they are still 'monitoringdashboards' resources, although if I had to name them today perhaps I would probably choose 'customdashboards'. In our documentation they are referred to as Custom Dashboards, but the CRD itself is still 'monitoringdashboards.

I'm not sure if this setting should be named just 'dashboard', to me it's a very broad term, for many users Kiali itself is a dashboard. I fear it could cause confusion.

[jotak]

Beside the comment about the name of that setting, lgtm. I've tested locally.

[jmazzitelli]

I'll rename to custom_dashboards

[jotak]

LGTM