Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new extensions configuration #787

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jmazzitelli
Copy link
Contributor

@jmazzitelli jmazzitelli commented Jun 27, 2024

@jmazzitelli jmazzitelli self-assigned this Jun 27, 2024
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor text changes. Should we go ahead and add an url attribute?

crd-docs/crd/kiali.io_kialis.yaml Outdated Show resolved Hide resolved
crd-docs/crd/kiali.io_kialis.yaml Outdated Show resolved Hide resolved
crd-docs/crd/kiali.io_kialis.yaml Outdated Show resolved Hide resolved
Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>
@jmazzitelli
Copy link
Contributor Author

Should we go ahead and add an url attribute?

Let's wait until we think more about how we are going to support external URLs

@jshaughn
Copy link
Contributor

I created an issue for this effort: kiali/kiali#7485

@jmazzitelli jmazzitelli added the requires server PR A PR requires additional changes in the backend code. label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires server PR A PR requires additional changes in the backend code.
Projects
Status: 🏗 In progress
2 participants