Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation for "login" and "ldap" auth strategies; add documentation for "openid" strategy #243

Merged

Conversation

israel-hdez
Copy link
Member

@israel-hdez israel-hdez commented Jun 4, 2020

@israel-hdez israel-hdez self-assigned this Jun 4, 2020
@israel-hdez israel-hdez added this to In Review in Sprint 40 via automation Jun 4, 2020
@israel-hdez israel-hdez changed the title Add deprecation warnings for "login" and "ldap" auth strategies Add deprecation for "login" and "ldap" auth strategies; add documentation for "openid" strategy Jun 4, 2020
@israel-hdez israel-hdez requested a review from jshaughn June 4, 2020 21:42
@lucasponce lucasponce added this to In Review in Sprint 41 via automation Jun 5, 2020
@lucasponce lucasponce removed this from In Review in Sprint 40 Jun 5, 2020
@israel-hdez israel-hdez marked this pull request as ready for review June 5, 2020 16:44
Copy link
Contributor

@cfcosta cfcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@israel-hdez israel-hdez merged commit 9db0478 into kiali:master Jun 8, 2020
Sprint 41 automation moved this from In Review to Done Jun 8, 2020
@israel-hdez israel-hdez deleted the openid-docs-login-ldap-deprecation branch June 8, 2020 15:53
mtho11 pushed a commit to mtho11/kiali.io that referenced this pull request Nov 18, 2020
…tion for "openid" strategy (kiali#243)

* Add deprecation warnings for "login" and "ldap" auth strategies

Part of kiali/kiali#2863 and kiali/kiali#2862.

* Add documentation for openid login strategy

Fixes kiali/kiali#2864
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Sprint 41
  
Done
2 participants