Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in the image generation due to incompatibilities in the rub… #595

Merged
merged 13 commits into from
Nov 11, 2022

Conversation

josunect
Copy link
Contributor

@josunect josunect commented Nov 7, 2022

Fix error in the image generation due to incompatibilities in the ruby and html proofer versions.

Ruby Version:

  • The new version (5.1) of htmlproofer requires ruby 3
  • Ruby 3.1 is the default in Fedora 36

htmlproofer errors:

  • The new html proofer version changed the way in which we should pass the new arguments. Ex.
    --check_external_hash false

Was changed by:
-no-check-internal-hash

Fixes kiali/kiali#5610

@josunect josunect added the bug Something isn't working label Nov 7, 2022
@josunect josunect self-assigned this Nov 7, 2022
@josunect
Copy link
Contributor Author

josunect commented Nov 7, 2022

Still need to investigate why we are getting these errors:

* At ./public/search/index.html:131:

  External link https://v1-58.kiali.io/ failed (status code 404)

I didn't got that locally.

Another issue is:

External link https://coreos.com/operators/ failed with something very wrong.
It's possible libcurl couldn't connect to the server, or perhaps the request timed out.
Sometimes, making too many requests at once also breaks things. (status code 0)

But this really doesn't exist (4 occurrences)

Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the initial issue is fixed, thanks. Now we are back to the issues prior to the build issue. Let's see if we can make progress there. If we can't solve it fairly easily then perhaps we should disable the checking.

@josunect
Copy link
Contributor Author

josunect commented Nov 8, 2022

A couple of notes:

  • It was doing a validation for a couple of versions in kiali.io (https://v1-XX.kiali.io) that where not available in kiali.io, so they are ignored in the validation (The current version and the previous).
  • Sometimes there are lots of errors in the validation, I think this is due to some kind of concurrency issue. The thypoeus parameters have been changed. But I don't see it very stable yet, so it may require some more adjustments.

There are many commits as I didn't have these issues in my local environment.

@jshaughn
Copy link
Contributor

jshaughn commented Nov 8, 2022

It was doing a validation for a couple of versions in kiali

I'm fine if the CI validates only staging.

Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG! One comment but you can ignore it if it doesn't make sense.

Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@josunect josunect merged commit f59a27b into kiali:staging Nov 11, 2022
@josunect josunect deleted the issue5610 branch November 11, 2022 14:42
hhovsepy pushed a commit to hhovsepy/kiali.io that referenced this pull request Apr 5, 2024
kiali#595)

* Fix error in the image generation due to incompatibilities in the ruby and html proofer versions

* Fix 404

* Remove current version from excluded urls

* Update script

* Show debug info

* Debug info

* Add debug info

* grep pattern

* grep pattern

* grep pattern

* grep pattern

* Update thyphoeus args

* Put exclude logic in the ignore_urls script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
2 participants