-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error in the image generation due to incompatibilities in the rub… #595
Conversation
…y and html proofer versions
Still need to investigate why we are getting these errors:
I didn't got that locally. Another issue is:
But this really doesn't exist (4 occurrences) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the initial issue is fixed, thanks. Now we are back to the issues prior to the build issue. Let's see if we can make progress there. If we can't solve it fairly easily then perhaps we should disable the checking.
A couple of notes:
There are many commits as I didn't have these issues in my local environment. |
I'm fine if the CI validates only staging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG! One comment but you can ignore it if it doesn't make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG!
kiali#595) * Fix error in the image generation due to incompatibilities in the ruby and html proofer versions * Fix 404 * Remove current version from excluded urls * Update script * Show debug info * Debug info * Add debug info * grep pattern * grep pattern * grep pattern * grep pattern * Update thyphoeus args * Put exclude logic in the ignore_urls script
Fix error in the image generation due to incompatibilities in the ruby and html proofer versions.
Ruby Version:
htmlproofer errors:
--check_external_hash false
Was changed by:
-no-check-internal-hash
Fixes kiali/kiali#5610