Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add steps to use Tempo as tracing storage via Tempo operator #677

Merged
merged 2 commits into from Jul 17, 2023

Conversation

iblancasa
Copy link
Contributor

Add a new section to explain how to use Tempo (with the Tempo Operator) as tracing storage.

Later, we can add more sections about how to do the same using Heml or other deployment modes that can be interesting for the users.

@jmazzitelli
Copy link
Contributor

Copy link
Contributor

@jmazzitelli jmazzitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't actually ran any of this, but other than the trivial change request, the documentation itself looks good.

provides a native Kubernetes solution to deploy Tempo easily in your system.

After installing the Tempo Operator in your cluster, you can create a new
Tempo instance with the following CRD:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a CRD (a CustomResourceDefinition).. this is an instance of the tempo CRD - aka a "Custom Resource" or CR:

Suggested change
Tempo instance with the following CRD:
Tempo instance with the following CR:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops. I typed too fast. Thanks!

@jshaughn
Copy link
Contributor

Thanks @iblancasa ! Last week we had a user get things working as described here, does that look correct to you, and does the PR cover his configuration?

@iblancasa
Copy link
Contributor Author

Thanks @iblancasa ! Last week we had a user get things working as described here, does that look correct to you, and does the PR cover his configuration?

I covered here the creation of a Tempo instance using the Kubernetes Operator. That description uses Helm. I think we should cover both. Also the method described in the official Tempo documentation. But as part of different PRs to make it easier to give feedback/review.

Sorry anyway for the delay. Lot of stuff in progress.

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@jshaughn jshaughn mentioned this pull request Jul 17, 2023
7 tasks
@jshaughn jshaughn changed the title Add steps to use Tempo as tracing storage Add steps to use Tempo as tracing storage via Tempo operator Jul 17, 2023
@jshaughn jshaughn requested a review from aljesusg July 17, 2023 18:31
@jshaughn
Copy link
Contributor

I covered here the creation of a Tempo instance using the Kubernetes Operator. That description uses Helm. I think we should cover both. Also kiali/kiali#5848 (comment). But as part of different PRs to make it easier to give feedback/review.

Ah, I see, thanks. This looks good to ne but I added @aljesusg as a reviewer. GIven your feedback I added two more subtasks to the Epic kiali/kiali#5850. One for Helm and one for Tempo docs. Will you be able to help with those as well?

Copy link
Contributor

@jmazzitelli jmazzitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Contributor

@aljesusg aljesusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@aljesusg aljesusg merged commit 1d92c8a into kiali:staging Jul 17, 2023
6 checks passed
@iblancasa
Copy link
Contributor Author

Ah, I see, thanks. This looks good to ne but I added @aljesusg as a reviewer. GIven your feedback I added two more subtasks to the Epic kiali/kiali#5850. One for Helm and one for Tempo docs. Will you be able to help with those as well?

Yes. I'll try my best :D

hhovsepy pushed a commit to hhovsepy/kiali.io that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
4 participants