Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gateway validation to VirtualServices #2932

Closed
xeviknal opened this issue Jun 23, 2020 · 4 comments
Closed

Add gateway validation to VirtualServices #2932

xeviknal opened this issue Jun 23, 2020 · 4 comments
Assignees
Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features.

Comments

@xeviknal
Copy link
Member

Right now, kiali only validate gateways in the spec.gateways field. There is no analysis for each route.gateways item. See the following example:

apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata:
  name: orahub-vs
  namespace: istio-trials
spec:
  hosts:
    - orahub.oci.oraclecorp.com
  gateways:
    - my-egress-gw
    - mesh
  http:
    - match:
        - gateways:
            - mesh
          port: 80
      route:
        - destination:
            host: istio-egressgateway.istio-system.svc.cluster.local
            port:
              number: 80
    - match:
        - gateways:
            - my-egress-gw
          port: 80
      route:
        - destination:
            subset: tls-origination
            host: orahub.oci.oraclecorp.com
            port:
              number: 443

my-egress-gw gateway should trigger a validation when there isn't any gateway available with this name.

@xeviknal xeviknal added enhancement This is the preferred way to describe new end-to-end features. refinement Still being full defined before taking any action labels Jun 23, 2020
@lucasponce
Copy link
Contributor

@xeviknal to me sounds a valid use case, I thought this case was already implemented.

@xeviknal
Copy link
Member Author

It was implemented for the main gateway list, not for each route. It should be pretty straightforward to implement that.

@lucasponce lucasponce added backlog Triaged Issue added to backlog and removed refinement Still being full defined before taking any action labels Feb 16, 2021
@lucasponce
Copy link
Contributor

Added to the Sprint to review priorities.

@lucasponce
Copy link
Contributor

Closed by #4158

@leandroberetta you can use the link syntax [1] in the PRs, then when the work is merged the issue will be closed automatically :-)

[1] https://docs.github.com/es/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features.
Projects
None yet
Development

No branches or pull requests

3 participants