Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics page: select all/none filter #3596

Closed
jotak opened this issue Jan 19, 2021 · 2 comments
Closed

Metrics page: select all/none filter #3596

jotak opened this issue Jan 19, 2021 · 2 comments
Assignees
@leandroberetta
Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features.

Comments

@jotak
Copy link
Contributor

jotak commented Jan 19, 2021

In metrics page, it becomes handy to have a select all/none option in the metrics filters when the number of available options grows substantially.

E.g. here, for Kiali internal metrics, having to deselect options one by one is cumbersome.
Capture d’écran de 2021-01-19 09-47-16

This is also relevant for istio metrics when a high number of versions are available, for instance.
@jotak jotak added the enhancement This is the preferred way to describe new end-to-end features. label Jan 19, 2021
@lucasponce
Copy link
Contributor

lucasponce commented Feb 15, 2021 •
edited
Loading

I think this pattern is already implemented in the namespace selector:
image

@lucasponce lucasponce added the backlog Triaged Issue added to backlog label Feb 16, 2021
@leandroberetta leandroberetta mentioned this issue Jun 24, 2021
Merged
@lucasponce
Copy link
Contributor

Closed by kiali/kiali-ui#2185

Friendly reminder, please, use the link feature on the PR to close automatically the issues when PR are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leandroberetta leandroberetta

Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@leandroberetta @lucasponce @jotak