Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple fetch problem on node double-click #3649

Closed
jshaughn opened this issue Jan 28, 2021 · 0 comments · Fixed by kiali/kiali-ui#2071
Closed

Fix multiple fetch problem on node double-click #3649

jshaughn opened this issue Jan 28, 2021 · 0 comments · Fixed by kiali/kiali-ui#2071
Assignees
@jshaughn
Labels
backlog Triaged Issue added to backlog bug Something isn't working
Projects
Sprint 52

Comments

@jshaughn
Copy link
Collaborator

When double-clicking on a graph node we're making two graph generation calls to the backend. Furthermore, when double clicking on an operation node, the initial request is corrupt.

We should only be making one, valid, graph generation call on a double-click.
@jshaughn jshaughn added bug Something isn't working backlog Triaged Issue added to backlog team/saturn labels Jan 28, 2021
@jshaughn jshaughn self-assigned this Jan 28, 2021
@jshaughn jshaughn added this to Backlog in Sprint 52 via automation Jan 28, 2021
@jshaughn jshaughn moved this from Backlog to In Progress in Sprint 52 Jan 28, 2021
jshaughn added a commit to jshaughn/kiali-ui that referenced this issue Jan 28, 2021
@jshaughn
We don't need to both update the URL and update redux on a double-click
bc00425 
Pushing a new node graph URL will already cause a redux update when the
page initializes. So, remove the redundancy and prevent two calls to the
backend.

Furthermore, fix an issue on operation node double-click by properly
setting the target node params.

kiali/kiali#3649
@jshaughn jshaughn mentioned this issue Jan 28, 2021
Merged
Sprint 52 automation moved this from In Progress to Done Feb 2, 2021
jshaughn added a commit to kiali/kiali-ui that referenced this issue Feb 2, 2021
@jshaughn
Prevent duplicate graph fetch on double-click (#2071)
c62f2fd 
* We don't need to both update the URL and update redux on a double-click
Pushing a new node graph URL will already cause a redux update when the
page initializes. So, remove the redundancy and prevent two calls to the
backend.

Furthermore, fix an issue on operation node double-click by properly
setting the target node params.

kiali/kiali#3649
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshaughn jshaughn

Labels
backlog Triaged Issue added to backlog bug Something isn't working
Projects
No open projects
Sprint 52
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent duplicate graph fetch on double-click jshaughn/kiali-ui
1 participant
@jshaughn