Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear validation message for services (port mismatch) at Service list #3872

Closed
xeviknal opened this issue Apr 13, 2021 · 3 comments
Closed
Assignees
Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features.

Comments

@xeviknal
Copy link
Member

Screenshot at 2021-04-06 16-50-17

Originally posted by @abonas in #3860

Kiali should render a more accurate message when there is one service with a validation. The message refers only to Istio objects, not to service problem itself.

@jshaughn
Copy link
Collaborator

@lucasponce Is it feasible to add more detailed information? If not terribly hard it seems like a good change. Add to the backlog as you see fit.

@lucasponce
Copy link
Contributor

@jshaughn Yes, this is also linked with this issue as well #1404 as there are a couple of validations that are splitted and it should get a better consistency way to show in the list and details and, yes, an improved the message, that tooltip is confusing as it is now.

I've planned #1404 for this Sprint and probably it may include this as well.

@jshaughn jshaughn added the backlog Triaged Issue added to backlog label May 11, 2021
@lucasponce lucasponce added the enhancement This is the preferred way to describe new end-to-end features. label Aug 10, 2021
@lucasponce
Copy link
Contributor

This one was missed.
The description of the tooltip should indicate that it's a "Service" validation based on Istio recommendation, but it's not an Istio resource validation

[1] https://kiali.io/documentation/latest/validations/#_kia0601_port_name_must_follow_protocol_suffix_form

@lucasponce lucasponce changed the title Unclear validation message for Services (port mismatch) at Service list Unclear validation message for services (port mismatch) at Service list Aug 10, 2021
@hhovsepy hhovsepy self-assigned this Sep 23, 2021
@hhovsepy hhovsepy closed this as completed Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features.
Projects
None yet
Development

No branches or pull requests

4 participants