Unable to edit IstioConfig

[hhovsepy]

Happens on master. A regression.

Open any ServiceEntry page via YAML editor, try to change and save. Error happens.

"Could not update IstioConfig details. Invalid JSON Patch"

No other logs in Kiali pod.

apiVersion: networking.istio.io/v1alpha3
kind: ServiceEntry
metadata:
  name: edition-cnn-com
  namespace: alpha
spec:
  hosts:
    - edition.cnn.com
  ports:
    - number: 80
      name: http-port
      protocol: HTTP
      targetPort: 443
    - number: 443
      name: https-port
      protocol: HTTPS
  resolution: DNS

"{\"kind\":\"ServiceEntry\",\"apiVersion\":\"networking.istio.io/v1alpha3\",\"metadata\":{\"name\":\"edition-cnn-com\",\"namespace\":\"bookinfo\",\"uid\":\"c858364b-189c-48e6-a11e-3afce81e5fc0\",\"resourceVersion\":\"162629\",\"generation\":5,\"creationTimestamp\":\"2021-09-20T12:15:33Z\",\"annotations\":{\"kubectl.kubernetes.io/last-applied-configuration\":\"{\\\"apiVersion\\\":\\\"networking.istio.io/v1alpha3\\\",\\\"kind\\\":\\\"ServiceEntry\\\",\\\"metadata\\\":{\\\"annotations\\\":{},\\\"name\\\":\\\"edition-cnn-com\\\",\\\"namespace\\\":\\\"bookinfo\\\"},\\\"spec\\\":{\\\"hosts\\\":[\\\"edition.cnn.com\\\"],\\\"ports\\\":[{\\\"name\\\":\\\"http-port\\\",\\\"number\\\":80,\\\"protocol\\\":\\\"HTTP\\\",\\\"targetPort\\\":443},{\\\"name\\\":\\\"https-port\\\",\\\"number\\\":443,\\\"protocol\\\":\\\"HTTPS\\\"}],\\\"resolution\\\":\\\"DNS\\\"}}\\n\"},\"managedFields\":[{\"manager\":\"kubectl-client-side-apply\",\"operation\":\"Update\",\"apiVersion\":\"networking.istio.io/v1alpha3\",\"time\":\"2021-09-20T12:15:33Z\",\"fieldsType\":\"FieldsV1\",\"fieldsV1\":{\"f:metadata\":{\"f:annotations\":{\".\":{},\"f:kubectl.kubernetes.io/last-applied-configuration\":{}}},\"f:spec\":{\".\":{},\"f:ports\":{},\"f:resolution\":{}}}},{\"manager\":\"Go-http-client\",\"operation\":\"Update\",\"apiVersion\":\"networking.istio.io/v1alpha3\",\"time\":\"2021-09-20T13:06:00Z\",\"fieldsType\":\"FieldsV1\",\"fieldsV1\":{\"f:spec\":{\"f:hosts\":{}}}}]},\"spec\":{\"hosts\":[\"edition2.cnn.com\"],\"addresses\":null,\"ports\":[{\"name\":\"http-port\",\"number\":80,\"protocol\":\"HTTP\",\"targetPort\":443},{\"name\":\"https-port\",\"number\":443,\"protocol\":\"HTTPS\"}],\"location\":null,\"resolution\":\"DNS\",\"endpoints\":null,\"workloadSelector\":null,\"exportTo\":null,\"subjectAltNames\":null}}"

[lucasponce]

I couldn't reproduce in master.
Did you change some fields at same time ?
I wonder if you reproduce always the bug.

[hhovsepy]

Just changing the hostname, a simple edit.

[pbajjuri20]

I have also try to change the Hostname against Master In serviceEntry, It is through an error.

[lucasponce]

@pbajjuri20 @hhovsepy which version of OpenShift are you using ?
I'm going to take it.

[pbajjuri20]

I have tested on OCP version: 4.8.5

[lucasponce]

Ok, it fails other Istio resources as well.
I have a suspect about where the problem is, I'll put it in the sprint.

[lucasponce]

Now with latest master I can reproduce the problem in minikube, so I guess bug is consistent.

[lucasponce]

Ouch, it was the axios library !

There is a PR that should solve the problem:
kiali/kiali-ui#2242

I had a random behaviour on this as when I changed from the branch in the UI project I was not updating the libs and then sometimes I could reproduce the problem and sometimes not.

But cleaning the node_modules and checking master with the PR will show that the PATCH query was failing.

If you can give a try to confirm, we can merge the patch as it's affecting to a couple of areas and better to consolidate.