Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After navigating to the Service graph, all other graphs are displayed with injectServiceNodes=false #6098

Closed
rsalmond opened this issue May 3, 2023 · 2 comments · Fixed by #6188
Assignees
Labels
backlog Triaged Issue added to backlog bug Something isn't working

Comments

@rsalmond
Copy link

rsalmond commented May 3, 2023

To repro, visit the Graph tab, click the "reset to factory settings" button, then use the drop down to choose "service graph", then use the drop down to select any other graph type and you should see app/workload displayed without the service icon.


Before:

image

URI: /kiali/console/graph/namespaces/?traffic=grpc%2CgrpcRequest%2Chttp%2ChttpRequest%2Ctcp%2CtcpSent&graphType=versionedApp&namespaces=blue%2Ccert-manager%2Cdefault%2Cistio-system%2Cprism%2Cred&duration=60&refresh=60000&layout=kiali-dagre&namespaceLayout=kiali-dagre


During:

image

URI: /kiali/console/graph/namespaces/?traffic=grpc%2CgrpcRequest%2Chttp%2ChttpRequest%2Ctcp%2CtcpSent&graphType=service&namespaces=blue%2Ccert-manager%2Cdefault%2Cistio-system%2Cprism%2Cred&duration=60&refresh=60000&layout=kiali-dagre&namespaceLayout=kiali-dagre&injectServiceNodes=false


After:

image

URI: /kiali/console/graph/namespaces/?traffic=grpc%2CgrpcRequest%2Chttp%2ChttpRequest%2Ctcp%2CtcpSent&graphType=versionedApp&namespaces=blue%2Ccert-manager%2Cdefault%2Cistio-system%2Cprism%2Cred&duration=60&refresh=60000&layout=kiali-dagre&namespaceLayout=kiali-dagre&injectServiceNodes=false

@rsalmond rsalmond added the bug Something isn't working label May 3, 2023
@jshaughn
Copy link
Collaborator

jshaughn commented May 3, 2023

You are right, it's sort of a known quirk. I'd have to look again to see if it's something we can get around. Thanks.

@jshaughn jshaughn added the backlog Triaged Issue added to backlog label May 3, 2023
@jshaughn
Copy link
Collaborator

This has confused enough people over the years, and looks reasonably easy to change, that we will do it.

@jshaughn jshaughn self-assigned this May 23, 2023
jshaughn added a commit to jshaughn/kiali that referenced this issue May 23, 2023
showServiceNodes and showOperationNodes.  The user shouldn't care that
those being enabled does not make sense for Service graphs, and shouldn't
get surprised by them suddenly getting disabled. Instead, let
the backend ignore those settings as needed.

kiali#6098
jshaughn added a commit that referenced this issue May 25, 2023
for showServiceNodes and showOperationNodes.  The user shouldn't care that
those being enabled does not make sense for Service graphs, and shouldn't
get surprised by them suddenly getting disabled. Instead, let
the backend ignore those settings as needed.

#6098
yzzeee pushed a commit to yzzeee/kiali that referenced this issue Jul 10, 2023
for showServiceNodes and showOperationNodes.  The user shouldn't care that
those being enabled does not make sense for Service graphs, and shouldn't
get surprised by them suddenly getting disabled. Instead, let
the backend ignore those settings as needed.

kiali/kiali#6098
yzzeee pushed a commit to yzzeee/kiali that referenced this issue Jul 10, 2023
for showServiceNodes and showOperationNodes.  The user shouldn't care that
those being enabled does not make sense for Service graphs, and shouldn't
get surprised by them suddenly getting disabled. Instead, let
the backend ignore those settings as needed.

kiali/kiali#6098
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Triaged Issue added to backlog bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants