Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve graph node labels - remove parentheses #6123

Closed
Tracked by #5618
jshaughn opened this issue May 9, 2023 · 0 comments · Fixed by #6142
Closed
Tracked by #5618

Improve graph node labels - remove parentheses #6123

jshaughn opened this issue May 9, 2023 · 0 comments · Fixed by #6142
Assignees
Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features. multicluster Related to multi cluster test: n/a PR does not need test additions or updates

Comments

@jshaughn
Copy link
Collaborator

jshaughn commented May 9, 2023

To add necessary discriminators to Graph node labels we append namespace and/or cluster names in parentheses. This has proven to be confusing and can also be hard to read. It originated before we used PF badges and can now be improved by using fully-badged information.

This is related to #5922, which suggests that we add back single-node parent-boxes. But that approach has proven to be cumbersome for larger graphs. Hopefully this will be sufficient. If not, we could add single-node boxing back, as a configurable ui-option (but I don't really want to).

Before:
image

After:
TBD

@jshaughn jshaughn added enhancement This is the preferred way to describe new end-to-end features. backlog Triaged Issue added to backlog labels May 9, 2023
@jshaughn jshaughn self-assigned this May 9, 2023
@josunect josunect mentioned this issue May 10, 2023
64 tasks
@matejnesuta matejnesuta added test-add-coverage 📎 this needs test coverage multicluster Related to multi cluster labels Aug 3, 2023
@matejnesuta matejnesuta added test: n/a PR does not need test additions or updates and removed test-add-coverage 📎 this needs test coverage labels Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features. multicluster Related to multi cluster test: n/a PR does not need test additions or updates
Projects
Development

Successfully merging a pull request may close this issue.

2 participants