[make] work around opm render bug when building for OLM

[jmazzitelli]

There is a bug in opm render ... see operator-framework/operator-registry#935 and operator-framework/operator-registry#919 ... both myself and @ferhoyos hit this when running make olm-operator-create (really, the problem is in the target build-olm-index).

There is an interesting workaround as you see here which seems based on this simple workaround here.

I think we might be able to do something simpler, but the idea is we should tell opm render what its DOCKER_CONFIG is (don't rely on the default environment).

I think if DORP=podman (meaning you are relying on podman for the image registry access), then the Makefile should simply create a softlink to the podman auth.json to a file called config.json (which is docker's name, and apparently what opm render looks at) and just point opm to the podman directory. So something as simple as this should work:

ln $XDG_RUNTIME_DIR/containers/auth.json $XDG_RUNTIME_DIR/containers/config.json
export DOCKER_CONFIG="$XDG_RUNTIME_DIR/containers"
opm render ...
unset DOCKER_CONFIG

Alternatively, copy the auth.json to the build output directory and point DOCKER_CONFIG there.

[jmazzitelli]

Here is how I see the issue:

1. Have at least one set of credentials in $HOME/.docker/config.json - if you do not, just do a docker login quay.io or docker login docker.io and make sure that file has some non-empty "auths" section.
2. Log into an OpenShift cluster and do a "podman login" to the image registry (you can get that podman login command via make -e DORP=podman cluster-status -- look at the end of the output).
3. Run make -e DORP=podman build-olm-index and see it fail with failed with status code [manifests v1.74.0]: 401 Unauthorized
4. Now delete (or move it out of the way if you want to restore it later) the $HOME/.docker/config.json file and run the make command again. It should now succeed.

[jmazzitelli]

We will want to do a similar fix for the OSSMC make target that is similar: https://github.com/kiali/openshift-servicemesh-plugin/blob/main/make/Makefile.olm.mk#L69