Replace strings with correct concatenation

[aljesusg]

There are multiple sentences in code with old concatenation, replace them with the new one `<string>` (Require template literals instead of string concatenation):

Rule:

In ES2015 (ES6), we can use template literals instead of string concatenation.

var str = "Hello, " + name + "!";

var str = `Hello, ${name}!`;

Example in kiali code:

kiali/frontend/src/types/Health.ts

Line 276 in efd78c6

text: prefix + ': ' + (thresholdStatus.status === NA ? 'No requests' : thresholdStatus.value.toFixed(2) + '%'),

that would be great to replace with

text: `${prefix}:${thresholdStatus.status === NA ? 'No requests' : `${thresholdStatus.value.toFixed(2)}%`}`

More information: http://eslint.org/docs/rules/prefer-template

[jshaughn]

I agree that the new way is better, and I would encourage the change as we work on the code, but I'm -1 for a straight refactor unless there is some benefit other than just nicer looking code. I do already change this when I see it, but you have to be careful not to make a mistake.

[jmazzitelli]

I agree with jay - we don't want a bunch of one-line PRs from random people that is just refactor string concat code.

[aljesusg]

Well...the point is that I am doing these changes for backstage effort, I must do it by repo rules (logically methods and some components with material-ui instead pf are identical - copy/paste).

I agree that it makes no sense make all the changes and I opened the issue looking for a contributor. If you want we can close it.

[jmazzitelli]

I believe this is getting taken care of with the linter stuff we now have in place. I'm seeing PRs that are getting created with these changes. So this issue may be getting implemented as time marches forward and the linter forces devs to make these changes.

[jshaughn]

+1, I will close this.