Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply new eslint rules only to edited files #6893

Closed
ferhoyos opened this issue Nov 29, 2023 · 3 comments · Fixed by #6897
Closed

Apply new eslint rules only to edited files #6893

ferhoyos opened this issue Nov 29, 2023 · 3 comments · Fixed by #6897
Assignees
Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features.

Comments

@ferhoyos
Copy link
Contributor

Due to Kiali application size it is very hard to introduce new eslint rules like #6736 (the number of errors after applying the eslint rule to whole Kiali application is so high that is impossible to handle correctly). For this reason I think we could apply new eslint rules only to edited files where developer is working (yarn lint:precommit command).

With this approach the new eslint rule is applied little by little to Kiali applicatiion. After some time these eslint rules could be incorporated to general eslint configuration when the number of errors is manageable.

@ferhoyos ferhoyos added the enhancement This is the preferred way to describe new end-to-end features. label Nov 29, 2023
@jshaughn
Copy link
Collaborator

This seems like a fair compromise, especially now that the PF5 update is complete. Although we may still need to skip that precommit hook on wide PRs, like the I18N PR, for example.

@ferhoyos
Copy link
Contributor Author

If it is just for special big PRs like i18n we can disable the precommit lint with the wide PR and immediately enable it with another PR when merged.

@jshaughn
Copy link
Collaborator

I think with this we can probably close #6736.

@jshaughn jshaughn added the backlog Triaged Issue added to backlog label Nov 29, 2023
@ferhoyos ferhoyos self-assigned this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features.
Projects
Development

Successfully merging a pull request may close this issue.

2 participants