Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] need to fix CI script for running molecule tests on openshift #6738

Closed
jmazzitelli opened this issue Oct 18, 2023 · 0 comments · Fixed by #6739
Closed

[ci] need to fix CI script for running molecule tests on openshift #6738

jmazzitelli opened this issue Oct 18, 2023 · 0 comments · Fixed by #6739
Assignees
@jmazzitelli
Labels
bug Something isn't working

Comments

@jmazzitelli
Copy link
Collaborator

jmazzitelli commented Oct 18, 2023 •
edited

I found a place I missed when integrating OSSMC into the Kiali operator - there is a CI hack script used to run nightly molecule tests on OpenShift that I forgot to change.

An option name changed from --use-default-server-image to --use-default-images, but the ci-openshift-molecule-tests.sh didn't get that change.

There is also a change that needs to be made to allow the OSSMConsole CR to be given a customizable spec.version. I will make that change here, also. This allows testing to be done with different spec.version values.

serverPR: #6739
operator PR: kiali/kiali-operator#695
@jmazzitelli jmazzitelli added the bug Something isn't working label Oct 18, 2023
@jmazzitelli jmazzitelli self-assigned this Oct 18, 2023
jmazzitelli added a commit to jmazzitelli/kiali that referenced this issue Oct 18, 2023
@jmazzitelli
use the new --use-default-images option.
0242466 
also allow for custom spec.version to be set in created ossmconsole cr
fixes: kiali#6738
@jmazzitelli jmazzitelli mentioned this issue Oct 18, 2023
Merged
jmazzitelli added a commit to jmazzitelli/kiali-operator that referenced this issue Oct 18, 2023
@jmazzitelli
be able to customize spec.version
0a6c7c9 
this goes with PR kiali/kiali#6739

part of kiali/kiali#6738
@jmazzitelli jmazzitelli mentioned this issue Oct 18, 2023
Merged
jmazzitelli added a commit to jmazzitelli/kiali that referenced this issue Oct 18, 2023
@jmazzitelli
use the new --use-default-images option.
f8e5a34 
also allow for custom spec.version to be set in created ossmconsole cr
fixes: kiali#6738
jmazzitelli added a commit that referenced this issue Oct 18, 2023
@jmazzitelli
use the new --use-default-images option. (#6739)
859a0cd 
also allow for custom spec.version to be set in created ossmconsole cr
fixes: #6738
jmazzitelli added a commit to kiali/kiali-operator that referenced this issue Oct 18, 2023
@jmazzitelli
be able to customize spec.version (#695)
5c88d1a 
this goes with PR kiali/kiali#6739

part of kiali/kiali#6738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmazzitelli jmazzitelli

Labels
bug Something isn't working
Projects
Kiali Sprint 24-5 | Kiali 1.84
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use the new --use-default-images option. jmazzitelli/kiali
1 participant
@jmazzitelli