Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway badge is not being applied to gateways in the graph #6740

Closed
jshaughn opened this issue Oct 18, 2023 · 4 comments · Fixed by #6747
Closed

Gateway badge is not being applied to gateways in the graph #6740

jshaughn opened this issue Oct 18, 2023 · 4 comments · Fixed by #6747
Assignees
@jshaughn
Labels
backlog Triaged Issue added to backlog backport completed Issue PRs have been backported backport needed Issue PRs require backport to versions specified in comments bug Something isn't working

Comments

@jshaughn
Copy link
Collaborator

It looks like the server is not reporting the Gateway hosts, which makes the UI think it's not a gateway. Looks like this has been an issue for several releases...
@jshaughn jshaughn added bug Something isn't working backlog Triaged Issue added to backlog labels Oct 18, 2023
@jshaughn jshaughn self-assigned this Oct 18, 2023
@lonnixrdc
Copy link

lonnixrdc commented Oct 18, 2023 •
edited

Here is an example: in the setup shown below there are actually 2 gateways using the same istio-ingressgateway deployment but the UI doesn't show anything about either of them. Both gateways route to the same nginx service.
image

jshaughn added a commit to jshaughn/kiali that referenced this issue Oct 18, 2023
@jshaughn
- Fix server-side issue in gateway detection
7c5aba6 
- Fix client-side issue with gateway icon, name change in PF5

kiali#6740
@jshaughn jshaughn mentioned this issue Oct 18, 2023
Merged
@jshaughn
Copy link
Collaborator Author

We should backport this to 1.73 (careful of the icon name change, that may not be necessary).

@jshaughn jshaughn added the backport needed Issue PRs require backport to versions specified in comments label Oct 18, 2023
jshaughn added a commit to jshaughn/kiali that referenced this issue Oct 19, 2023
@jshaughn
- Fix server-side issue in gateway detection
1d6a9d0 
- Fix client-side issue with gateway icon, name change in PF5

kiali#6740
jshaughn added a commit that referenced this issue Oct 20, 2023
@jshaughn
Fix issues with gateway-badging in graph (#6747)
cf279ec 
- Fix server-side issue in gateway detection
- Fix client-side issue with gateway icon, name change in PF5

#6740
@aljesusg
Copy link
Collaborator

Needed the backport to 1.73 then we can close this one

@aljesusg aljesusg reopened this Oct 24, 2023
@jshaughn
Copy link
Collaborator Author

It's not really necessary to have the original issue open to perform the backport. But thanks for the reminder!

jshaughn added a commit to jshaughn/kiali that referenced this issue Oct 24, 2023
@jshaughn
Fix issues with gateway-badging in graph (kiali#6747)
4faecb4 
- Fix server-side issue in gateway detection
- Fix client-side issue with gateway icon, name change in PF5

kiali#6740
@jshaughn jshaughn mentioned this issue Oct 24, 2023
Merged
jshaughn added a commit that referenced this issue Oct 24, 2023
@jshaughn
[v1.73] Fix issues with gateway-badging in graph (#6770)
463bb54 
* Fix issues with gateway-badging in graph (#6747)
- Fix server-side issue in gateway detection

Backport for #6740
@jshaughn jshaughn added the backport completed Issue PRs have been backported label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshaughn jshaughn

Labels
backlog Triaged Issue added to backlog backport completed Issue PRs have been backported backport needed Issue PRs require backport to versions specified in comments bug Something isn't working
Projects
Kiali Sprint 24-5 | Kiali 1.84
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues with gateway-badging in graph jshaughn/kiali
3 participants
@jshaughn @aljesusg @lonnixrdc