Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup-kind-ci.sh script fails if it is not executed from root folder #6750

Closed
ferhoyos opened this issue Oct 19, 2023 · 2 comments · Fixed by #6755
Closed

setup-kind-ci.sh script fails if it is not executed from root folder #6750

ferhoyos opened this issue Oct 19, 2023 · 2 comments · Fixed by #6755
Assignees
Labels
backlog Triaged Issue added to backlog backport completed Issue PRs have been backported backport needed Issue PRs require backport to versions specified in comments bug Something isn't working

Comments

@ferhoyos
Copy link
Contributor

The script setup-kind-ci.sh fails if it is executed from any folder except kiali root:

image

Path to hack/istio/download-istio.sh should be absolute and not relative.

@ferhoyos ferhoyos added the bug Something isn't working label Oct 19, 2023
@jmazzitelli
Copy link
Collaborator

the way we typically handle this in the easiest way is to put a couple lines at the top - find the directory where the script is found, then cd to that directory. At that point, every path in the script can be coded to assume that location (so it doesn't matter where you run the script from, its CWD will always be the location where the script is located).

e.g.

@ferhoyos ferhoyos self-assigned this Oct 19, 2023
@ferhoyos ferhoyos added the backport needed Issue PRs require backport to versions specified in comments label Oct 24, 2023
@aljesusg aljesusg reopened this Oct 24, 2023
@aljesusg
Copy link
Collaborator

Needed the backport to 1.73 then we can close this one

@jshaughn jshaughn added the backlog Triaged Issue added to backlog label Oct 25, 2023
@ferhoyos ferhoyos added the backport completed Issue PRs have been backported label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Triaged Issue added to backlog backport completed Issue PRs have been backported backport needed Issue PRs require backport to versions specified in comments bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

4 participants