[1.73] Add absolute script dir path in setup-kind-ci.sh script (#6755) #6789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmazzitelli
approved these changes
Oct 27, 2023
|
Sorry but Why we need to backport this? It's not a bug in the product. Do we need it to test something? |
I assumed it was to be able to run the tests within this branch (??) |
|
Actually the bug does not break the tests, it is just only for developers. I set the backport label to this bug by mistake. Anyway, since it is done and reviewed, there is no harm to backport this change, right? |
|
no harm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Backport of #6755 to version 1.73. There are more changes than in referenced PR because there are previous PRs modifying this file that have not been backported. For this reason I have pushed the latest version of the hack script into v1.73.
Issue reference
Closes #6750