Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getNamespaceMetrics includes cluster in query params #6753

Closed
ferhoyos opened this issue Oct 19, 2023 · 0 comments · Fixed by #6756
Closed

getNamespaceMetrics includes cluster in query params #6753

ferhoyos opened this issue Oct 19, 2023 · 0 comments · Fixed by #6756
Assignees
Labels
backlog Triaged Issue added to backlog backport completed Issue PRs have been backported backport needed Issue PRs require backport to versions specified in comments bug Something isn't working

Comments

@ferhoyos
Copy link
Contributor

Reviewing #6731, I have noticed that API getNamespaceMetrics sends cluster as query param, which breaks the clusterName query param convention to avoid #6322.

promiseIn = API.getNamespaceMetrics(namespace, {
        byLabels: ['request_protocol'], // ignored by prom if it doesn't exist
        cluster: cluster,
        direction: 'inbound',
        duration: props.duration,
        filters: filters,
        queryTime: props.queryTime,
        rateInterval: props.rateInterval,
        reporter: 'destination',
        step: props.step
      } as IstioMetricsOptions);

Effectively, if you hit the namespace label in the graph, cluster query param is sent:

image

image

@ferhoyos ferhoyos added the bug Something isn't working label Oct 19, 2023
@ferhoyos ferhoyos self-assigned this Oct 19, 2023
@jshaughn jshaughn added the backlog Triaged Issue added to backlog label Oct 25, 2023
@ferhoyos ferhoyos added the backport needed Issue PRs require backport to versions specified in comments label Oct 26, 2023
@ferhoyos ferhoyos added the backport completed Issue PRs have been backported label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Triaged Issue added to backlog backport completed Issue PRs have been backported backport needed Issue PRs require backport to versions specified in comments bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants