Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster param is invalid in Openshift Plugin #6322

Closed
Tracked by #6261
ferhoyos opened this issue Jun 29, 2023 · 0 comments · Fixed by #6325
Closed
Tracked by #6261

Cluster param is invalid in Openshift Plugin #6322

ferhoyos opened this issue Jun 29, 2023 · 0 comments · Fixed by #6325
Assignees
Labels
backlog Triaged Issue added to backlog bug Something isn't working sub-task Ties an issue to an epic

Comments

@ferhoyos
Copy link
Contributor

When Kiali is deployed as Openshift plugin (kiali/openshift-servicemesh-plugin), cluster param in HTTP request used for Multicluster feature is considered invalid:

For example:
api/istio/status?cluster=Kubernetes throws 400 Bad Request. Invalid cluster Kubernetes

image

This error does not happen when Kiali is used as standalone application within Openshift.

image

According to https://github.com/openshift/enhancements/blob/master/enhancements/console/dynamic-plugins.md#delivering-plugins, Openshift uses an internal proxy to redirect plugin HTTP requests to corresponding service (in this case Kiali backend service). It seems that cluster param is reserved for internal use within Openshift Console, which validates the cluster name (in a different way that Kiali does).

For example cluster param is used below in internal Openshift API (in this case cluster=local-cluster)

image

If we use same value cluster=local-cluster for Kiali, the HTTP request is not rejected by Openshift but the cluster is not found in Kiali (Kubernetes is the default cluster name):

image

For this reason cluster param should be renamed to meshcluster or similar to avoid conflicts with Openshift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Triaged Issue added to backlog bug Something isn't working sub-task Ties an issue to an epic
Projects
Development

Successfully merging a pull request may close this issue.

2 participants