Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kiali operator cannot determine kiali version when installing ossmc #6950

Closed
jmazzitelli opened this issue Dec 12, 2023 · 2 comments · Fixed by kiali/kiali-operator#731
Closed
Assignees
Labels
backport completed Issue PRs have been backported backport needed Issue PRs require backport to versions specified in comments bug Something isn't working

Comments

@jmazzitelli
Copy link
Collaborator

jmazzitelli commented Dec 12, 2023

Install Sail, Kiali, OSSMC using all community operators. The operator auto-detects Kiali and installs OSSMC fine and it works. However, it does not log the kialiVersion correctly:

$ oc get ossmconsole ossmconsole -n ossmconsole -o jsonpath='{.status.environment}' | jq
{
  "kialiVersion": "unknown",
  "kubernetesVersion": "1.26.5+7a891f0",
  "openshiftVersion": "4.13.3",
  "operatorVersion": "v1.78.0"
}

Find out why it can't figure out the version and fix that.

@jmazzitelli jmazzitelli added the bug Something isn't working label Dec 12, 2023
@jmazzitelli jmazzitelli changed the title ossmc cannot determine kiali version kiali operator cannot determine kiali version when installing ossmc Dec 12, 2023
@jmazzitelli
Copy link
Collaborator Author

jmazzitelli commented Dec 12, 2023

I think the reason for this is that the Kiali CR and the OSSMConsole CR were created at roughly the same time. So the Kiali pod didn't fully start by the time the version check ran. Perhaps we can add a simple while loop here so it can retry a few times before giving up. The version field isn't necessary for OSSMC to function properly, but it is very helpful for debugging and support.

@jmazzitelli jmazzitelli self-assigned this Dec 12, 2023
jmazzitelli added a commit to jmazzitelli/kiali-operator that referenced this issue Dec 12, 2023
@jmazzitelli jmazzitelli added the backport needed Issue PRs require backport to versions specified in comments label Dec 12, 2023
jmazzitelli added a commit to jmazzitelli/kiali-operator that referenced this issue Dec 12, 2023
jmazzitelli added a commit to jmazzitelli/kiali-operator that referenced this issue Dec 12, 2023
jmazzitelli added a commit to jmazzitelli/kiali-operator that referenced this issue Dec 12, 2023
jmazzitelli added a commit to jmazzitelli/kiali-operator that referenced this issue Dec 12, 2023
@jmazzitelli
Copy link
Collaborator Author

The additional benefit of this is that the OSSMConsole won't be installed until Kiali endpoint is fully ready. Therefore, as soon as the plugin is running, the user should be able to use it right away (as opposed to waiting for Kiali to be ready or, most likely, getting some odd behavior of the plugin because it can't talk to Kiali initially).

@jmazzitelli jmazzitelli added the backport completed Issue PRs have been backported label Dec 12, 2023
jmazzitelli added a commit to kiali/kiali-operator that referenced this issue Dec 14, 2023
jmazzitelli added a commit to kiali/kiali-operator that referenced this issue Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport completed Issue PRs have been backported backport needed Issue PRs require backport to versions specified in comments bug Something isn't working
Projects
1 participant