Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove graph "Compress-On-Hide" Display option #7030

Closed
jshaughn opened this issue Jan 15, 2024 · 0 comments · Fixed by #7031
Closed

Remove graph "Compress-On-Hide" Display option #7030

jshaughn opened this issue Jan 15, 2024 · 0 comments · Fixed by #7031
Assignees
@jshaughn
Labels
enhancement This is the preferred way to describe new end-to-end features.

Comments

@jshaughn
Copy link
Collaborator

jshaughn commented Jan 15, 2024 •
edited

This Display option is probably not used, and likely is not well-understood. It has historically been flaky and now, with the addition of the new "Show Waypoints" option, the Display menu is getting very long, often occluding the on-screen graph icons. Finally, the feature can not be offered in the Patternfly version of the graph, only Cytoscape.

When Compress-on-hide is enabled, which is the default, it means that when the user hides graph elements (via find/hide) there will be a graph re-layout in order to compress the graph into a smaller form, after the nodes are removed. When not enabled the graph elements remain in place, with the missing elements simply being removed. This is rarely, if ever, desired, and so for simplicity, this option will be removed.

Note that when disabling compress-on-hide, when evaluating this idea, the option crashed the graph display. That was unexpected but just one more reason to remove it, and one more reason to believe that users are not using the option.
@jshaughn jshaughn added the enhancement This is the preferred way to describe new end-to-end features. label Jan 15, 2024
@jshaughn jshaughn self-assigned this Jan 15, 2024
jshaughn added a commit to jshaughn/kiali that referenced this issue Jan 15, 2024
@jshaughn
Remove graph CompressOnHide option.
c8b45f0 
kiali#7030
@jshaughn jshaughn mentioned this issue Jan 15, 2024
Merged
@jshaughn jshaughn changed the title Remove graph "Compress-On_hide" Display option Remove graph "Compress-On-hide" Display option Jan 15, 2024
@jshaughn jshaughn changed the title Remove graph "Compress-On-hide" Display option Remove graph "Compress-On-Hide" Display option Jan 15, 2024
jshaughn added a commit to jshaughn/kiali that referenced this issue Jan 15, 2024
@jshaughn
Remove graph CompressOnHide option.
3561f1e 
kiali#7030
jshaughn added a commit to jshaughn/kiali that referenced this issue Jan 15, 2024
@jshaughn
Remove graph CompressOnHide option so that CompressOnHide is assumed …
dd9709c 
…(i.e.

always compress).

This PR also fixes an issue introduced with the refactor to use "kialiStyle".
It was mistakenly applied to replace the valid `elems.style()` function in
cytoscape.

kiali#7030
jshaughn added a commit that referenced this issue Jan 16, 2024
@jshaughn
Remove graph CompressOnHide option so that CompressOnHide is assumed (#…
7eb7107 
…7031)

(i.e. always compress).

This PR also fixes an issue introduced with the refactor to use "kialiStyle".
It was mistakenly applied to replace the valid `elems.style()` function in
cytoscape.

#7030
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshaughn jshaughn

Labels
enhancement This is the preferred way to describe new end-to-end features.
Projects
Kiali Sprint 24-5 | Kiali 1.84
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove graph CompressOnHide option. jshaughn/kiali
1 participant
@jshaughn