Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added NPM requirement in the readme prerequisites #3300

Merged
merged 1 commit into from Oct 7, 2020
Merged

Added NPM requirement in the readme prerequisites #3300

merged 1 commit into from Oct 7, 2020

Conversation

swapnadeepmohapatra
Copy link
Contributor

I have added npm as a requirement for building Kiali in the readme.

This fixes #1375

Thanks,
Swapnadeep

mtho11
mtho11 approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@mtho11 mtho11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtho11 mtho11 merged commit 819c84f into kiali:master Oct 7, 2020
@ghost ghost added this to the v1.25.0 milestone Oct 7, 2020
@mtho11
Copy link
Contributor

mtho11 commented Oct 7, 2020

nice catch @swapnadeepmohapatra!

@swapnadeepmohapatra
Copy link
Contributor Author

Thank you !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtho11 mtho11 mtho11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.25.0
Development

Successfully merging this pull request may close these issues.

NPM required for building Kiali but not mentioned in the readme prerequisites
2 participants
@swapnadeepmohapatra @mtho11