Support new 'includeIdleEdges` option. False by default. #3522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshaughn
added
requires UI PR
|
You should run the "api-test" molecule test - I suspect the graph test might be affected by this - consider adding to that test as well. See: https://github.com/kiali/kiali-operator/blob/master/molecule/api-test/graph.test.yaml |
@jmazzitelli OK, I finally ran the |
pbajjuri20
previously approved these changes
Dec 14, 2020
jshaughn
dismissed stale reviews from pbajjuri20 and jmazzitelli
via
5e1c7d1
jmazzitelli
approved these changes
Dec 15, 2020
|
Deployed and tested the new changes on "Idle Nodes" and "Idle Edges"
|
lucasponce
approved these changes
Dec 16, 2020
pbajjuri20
approved these changes
Dec 16, 2020
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server-side support in the graph code, to support the new
includeIdleEdgesoption.UI PR: kiali/kiali-ui#2037
Part of #3519