Added support of exported DestinationRules for SubsetPresenceChecker of VirtualSevices. Added tests. #4283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of VirtualSevices. Added tests.
|
For QE: Create the VS in bookinfo: You can see that v3 subset it marked as warning subset not found, because bookinfo3's DR is exported to bookinfo2. Play a bit with exportTo fields, make sure that a subset will not be available for bookinfo namespace and the VS will display warning. |
|
thank you @prachiyadav and @xeviknal |
ghost
added this to the 
|
Test Case >> SWSQE-1883 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second PR for RFE #3061
Added Cross Namespace validations for SubsetPresenceChecker of Virtual Services.
Added support of exportTo field for validation "KIA1107 Subset not found".