Install script fixes #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cfcosta I don't recall having issues with the istio scripts, so I am wondering - if this is going to be merged, will I now experience errors? :) (specifically the paths fix) |
|
@abonas it was not working for me at all, can you check this branch to see if it does work? |
jmazzitelli
requested changes
Feb 19, 2018
hack/istio-bookinfo-openshift.sh
Outdated
| @@ -8,7 +10,7 @@ if [ "$?" != 0 ]; then | |||
| fi | |||
|
|
|||
| # find istio that we installed from the install script | |||
| INSTALL_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )/.." && pwd )/_output/istio" | |||
| INSTALL_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )/../.." && pwd )/_output/istio" | |||
There was a problem hiding this comment.
are you sure about this? The script is in the hack directory. Go up to the parent and there is our build's "_output" directory. Going up two parent directories seems incorrect. Am I missing something?
What we want is to reuse the _output directory that is used by the Makefile. This directory: <root>/src/github.com/swift-sunshine/swscore/_output
There was a problem hiding this comment.
@jmazzitelli that was my ask too.
jmazzitelli
approved these changes
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some of the errors I've got when trying to run oc+istio with the provided hack scripts.