Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore cache files from pytest e2e suite #512

Merged
merged 1 commit into from Sep 21, 2018

Conversation

xeviknal
Copy link
Member

** Describe the change **
Running pytest produces some files for caching purposes. As they are not intended to be tracked, I propose to add them into gitignore.

** Backwards incompatible? **
yep.

@rhqci
Copy link

rhqci commented Sep 21, 2018

✔️ Jenkins CI: kiali-core-pr-e2e-test #77

KIALI_NAME=kialicorepr512-istio-system

@mattmahoneyrh
Copy link
Contributor

mattmahoneyrh commented Sep 21, 2018

The e2e failure is due to test case test_kiali_endpoint.py, which has since been removed from the repo.

mattmahoneyrh
mattmahoneyrh previously approved these changes Sep 21, 2018
@rhqci
Copy link

rhqci commented Sep 21, 2018

✔️ Jenkins CI: kiali-core-pr-e2e-test #78

KIALI_NAME=kialicorepr512-istio-system

@xeviknal
Copy link
Member Author

@mattmahoneyrh rebased and test passing.

@mattmahoneyrh mattmahoneyrh merged commit 0ec03f6 into kiali:master Sep 21, 2018
@xeviknal xeviknal deleted the ignore-e2e-cache branch September 21, 2018 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants