Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide contributions guide #547

Merged
merged 2 commits into from Oct 10, 2018
Merged

Provide contributions guide #547

merged 2 commits into from Oct 10, 2018

Conversation

pilhuhn
Copy link
Contributor

@pilhuhn pilhuhn commented Oct 8, 2018

Replaces #369

@rhqci
Copy link

rhqci commented Oct 8, 2018

✔️ Jenkins CI: kiali-core-pr-e2e-test #149

KIALI_NAME=kialicorepr547-istio-system

jotak
jotak approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jotak
Copy link
Contributor

jotak commented Oct 10, 2018

I think it's good to merge. Thanks @pilhuhn

@jotak jotak merged commit 86af71d into kiali:master Oct 10, 2018
@pilhuhn pilhuhn deleted the pr-369 branch October 11, 2018 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotak jotak jotak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pilhuhn @rhqci @jotak