Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIALI-1727 Fix how multimatch destination rule validation is shown in ACEditor #550

Merged
merged 1 commit into from Oct 10, 2018

Conversation

xeviknal
Copy link
Member

** Describe the change **
Showing multimatch DR validation properly in ACEditor. See the screenshots for better understanding.

** Issue reference **
https://issues.jboss.org/browse/KIALI-1727

Error:
screenshot of kiali console 3

Fix:
screenshot of kiali console 2

@rhqci
Copy link

rhqci commented Oct 10, 2018

✔️ Jenkins CI: kiali-core-pr-e2e-test #165

KIALI_NAME=kialicorepr550-istio-system

@xeviknal xeviknal requested a review from jotak October 10, 2018 13:20
Copy link
Contributor

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jotak jotak merged commit 5e955ca into kiali:master Oct 10, 2018
@hhovsepy
Copy link
Contributor

Verified

@xeviknal xeviknal deleted the KIALI-1727 branch October 10, 2018 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants