Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not hardcode istio label names #6125

Merged
merged 1 commit into from May 10, 2023
Merged

do not hardcode istio label names #6125

merged 1 commit into from May 10, 2023

Conversation

jmazzitelli
Copy link
Collaborator

fixes: #6124

@jmazzitelli jmazzitelli self-assigned this May 9, 2023
This was referenced May 9, 2023
Merged
Closed
leandroberetta
leandroberetta approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@leandroberetta leandroberetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jmazzitelli jmazzitelli merged commit 2fdf694 into kiali:master May 10, 2023
5 checks passed
@jmazzitelli jmazzitelli deleted the 6124-labels branch May 10, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandroberetta leandroberetta leandroberetta approved these changes

Assignees

@jmazzitelli jmazzitelli

Labels
None yet
Projects
Kiali Sprint 24-5 | Kiali 1.84
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hardcoded label name
2 participants
@jmazzitelli @leandroberetta