Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contextual menu for read links for remote clusters #6151

Merged
merged 2 commits into from May 17, 2023

Conversation

josunect
Copy link
Contributor

image

There was some code that was removed, because it was expecting a link to a remote kiali instance, but in this case, we want the link to be in this Kiali instance (We are just expecting one)

Fixes #6150

@josunect josunect added the enhancement This is the preferred way to describe new end-to-end features. label May 16, 2023
@josunect josunect self-assigned this May 16, 2023
@josunect josunect marked this pull request as draft May 16, 2023 14:29
@josunect josunect marked this pull request as ready for review May 16, 2023 19:20
Copy link
Contributor

@leandroberetta leandroberetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@josunect josunect merged commit d70fa7c into kiali:master May 17, 2023
5 checks passed
@josunect josunect deleted the issue6150 branch May 17, 2023 16:56
@ScriptingShrimp ScriptingShrimp added test-add-coverage 📎 this needs test coverage multicluster Related to multi cluster labels Aug 14, 2023
@matejnesuta matejnesuta added test: front-end/cypress PR adds/updates front-end tests (unit and/or cypress automation ) and removed test-add-coverage 📎 this needs test coverage labels Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is the preferred way to describe new end-to-end features. multicluster Related to multi cluster test: front-end/cypress PR adds/updates front-end tests (unit and/or cypress automation )
Projects
Development

Successfully merging this pull request may close these issues.

Add contextual menu in the nodes for the remote cluster
4 participants