Added cluster param in Istiod status request, Overview page and Masthead #6170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josunect
reviewed
May 23, 2023
| @@ -957,7 +957,9 @@ export class OverviewPage extends React.Component<OverviewProps, State> { | |||
| title={ns.name} | |||
| > | |||
| {ns.name} | |||
| {ns.name === serverConfig.istioNamespace && <ControlPlaneBadge></ControlPlaneBadge>} | |||
| {ns.name === serverConfig.istioNamespace && ( | |||
There was a problem hiding this comment.
Now in multi cluster, we have the possibility to have a remote cluster with the istioNamespace but no Istiod, what do you think to extend this check to this condition? Or maybe we can think about this when the Overview page is re worked?
There was a problem hiding this comment.
I would leave that for next iteration with Overview rework. To keep this PR only for adding cluster param.
ScriptingShrimp
added
multicluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFE #6169