Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote cluster - Istio Configs Editable #6240

Merged
merged 3 commits into from Jun 13, 2023
Merged

Conversation

hhovsepy
Copy link
Contributor

@hhovsepy hhovsepy commented Jun 7, 2023

RFE #6239

Remote clusters Istio Configs can be edited in 3 places now:

  1. Config Details YAML editor. Edit and Delete.
  2. Overview Page Namespace card. Create, Update, Delete traffic policies.
  3. Service Details page Traffic Wizard. Crete, Update, Delete traffic.

Screenshot from 2023-06-09 19-33-00
Screenshot from 2023-06-09 19-32-43
Screenshot from 2023-06-09 19-32-12

TODO: Istio Config creation wizard is a separate epic.

@hhovsepy hhovsepy changed the title Istio Configs Create/Edit/Deletable Remote cluster - Istio Configs Editable Jun 9, 2023
@hhovsepy hhovsepy marked this pull request as ready for review June 9, 2023 17:37
@hhovsepy hhovsepy self-assigned this Jun 9, 2023
Copy link
Contributor

@leandroberetta leandroberetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hhovsepy hhovsepy merged commit dbe2667 into kiali:master Jun 13, 2023
5 checks passed
@ScriptingShrimp ScriptingShrimp added test-add-coverage 📎 this needs test coverage multicluster Related to multi cluster labels Aug 9, 2023
@ScriptingShrimp
Copy link
Contributor

@hhovsepy

Remote clusters Istio Configs can be edited in 3 places now:

  1. Config Details YAML editor. Edit and Delete.
  2. Overview Page Namespace card. Create, Update, Delete traffic policies.
  3. Service Details page Traffic Wizard. Crete, Update, Delete traffic.

Please consider if following scenarios should be covered by multi or single cluster regression.

Suggested scenarios:

  1. CRUD traffic policies on remote cluster for each place (3 scenarios)
  2. Check propagated changes by kubectl
  3. revert policies by kubectl

@matejnesuta mc traffic policies

@hhovsepy
Copy link
Contributor Author

@hhovsepy

Remote clusters Istio Configs can be edited in 3 places now:

  1. Config Details YAML editor. Edit and Delete.
  2. Overview Page Namespace card. Create, Update, Delete traffic policies.
  3. Service Details page Traffic Wizard. Crete, Update, Delete traffic.

Please consider if following scenarios should be covered by multi or single cluster regression.

Suggested scenarios:

1. CRUD traffic policies on remote cluster for each place (3 scenarios)

2. Check propagated changes by kubectl

3. revert policies by kubectl

@matejnesuta mc traffic policies

@ScriptingShrimp those scenarios seems fine to me, send a PR with scenarios.

@matejnesuta matejnesuta added test: n/a PR does not need test additions or updates and removed test-add-coverage 📎 this needs test coverage labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multicluster Related to multi cluster test: n/a PR does not need test additions or updates
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants