Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config deletion - Fixed null replacement in json #6501

Merged
merged 3 commits into from Aug 22, 2023

Conversation

hhovsepy
Copy link
Contributor

@hhovsepy hhovsepy commented Aug 22, 2023

Issue #6374

At some point " does not exist in json from YAML for deleted array lines.

Copy link
Contributor

@josunect josunect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Verified with a Destination rule: It was not possible to remove name: v2:

kind: DestinationRule
apiVersion: networking.istio.io/v1beta1
metadata:
  name: details
  namespace: bookinfo
  uid: 5353eb43-a9bb-47bd-bbcf-993130106fcd
  resourceVersion: '21906'
  generation: 6
  creationTimestamp: '2023-08-22T12:23:28Z'
  labels:
    kiali_wizard: request_routing
  managedFields:
    - manager: kiali_core
      operation: Update
      apiVersion: networking.istio.io/v1beta1
      time: '2023-08-22T12:42:08Z'
      fieldsType: FieldsV1
      fieldsV1:
        'f:metadata':
          'f:labels':
            .: {}
            'f:kiali_wizard': {}
        'f:spec':
          .: {}
          'f:host': {}
          'f:subsets': {}
spec:
  host: details.bookinfo.svc.cluster.local
  subsets:
    - name: v1
      labels:
        version: v1
    - name: v2
      labels:
        version: v2
status: {}

It is possible to remove now.

@hhovsepy hhovsepy merged commit 0eb3eaa into kiali:master Aug 22, 2023
6 checks passed
@jshaughn jshaughn added backport needed Issue PRs require backport to versions specified in comments backport completed Issue PRs have been backported labels Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport completed Issue PRs have been backported backport needed Issue PRs require backport to versions specified in comments
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants