Gateway API class selector in K8s Gateway Istio config wizard #6585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshaughn
approved these changes
Sep 12, 2023
| @@ -64,6 +64,7 @@ const propsToShow = [ | |||
| 'authStrategy', | |||
| 'clusters', | |||
| 'gatewayAPIEnabled', | |||
| 'gatewayAPIClasses', | |||
There was a problem hiding this comment.
trivial - alphabetized out of order in a few places (not a blocker, can fix in some other PR)
| @@ -174,6 +186,20 @@ export class K8sGatewaySelector extends React.Component<Props, K8sGatewaySelecto | |||
| )} | |||
| {this.state.newGateway && ( | |||
| <> | |||
| {serverConfig.gatewayAPIClasses.length > 1 && ( | |||
There was a problem hiding this comment.
I guess another option would be to always display this so that the user can see the set value. But this approach is fine as well, not a blocker.
There was a problem hiding this comment.
I made the Gateway Classes available in Debug info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #6429
When there are more than 2 Gateway classes configured in Kiali CR
In both wizards, Kiali Service -> Create K8s Gateway API Routing and Istio Config -> Create K8s Gateway, it appears dropdown to select the Gateway API implementation: