New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSSM-5306][OSSM-5307] Add building tests images workflow into pipeline #6938
Conversation
8ca3dfd
to
948e53c
Compare
Ready for review. The description was updated to reflect recent changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkralik3 Good work, Everything looks fine. My only comments are just cosmetic. In English things will be a little more clear by removing some unnecessary plurals. I made a few suggestions in the comments. Also, in the file names please change "tests-" to "test-", thanks!
test-images-creator.yml
test-images-release.yml
test-images-update-latest.yml
42bec3c
to
856ac26
Compare
856ac26
to
13e7be5
Compare
@jshaughn Thanks. Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I can see images in quay. Not sure how to run workflows before merge, but will try right after.
@mkralik3 please feel free to close the Jiras
push: | ||
branches: | ||
- master | ||
paths: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing is missing here 👍
@ScriptingShrimp Since this is going only into v1.65, it will be running only when a new v1.65 tag is created there. To test manual workflow (see it in the actions page), you need to merge the backport into the master. Since this is done, I have set backports pull requests to |
Describe the change
Adding a workflow (
tests-images-creator.yml
) for building and pushing integration and cypress test images (both at once or a particular one). The workflow can be run from a different workflow or manually (e.g. for manually rebuilding a particular tag).tests-images-update-latest.yml
job, which is watching folders related to tests. If something is pushed into those folders, the job detects in which folders the changes were done and rebuilds the cypress, integration, or both test images accordingly. So thelatest
tag will always contain the latest changes in test suites.2 In addition, the workflow is called whenever a new tag is created (e.g. after release) by
tests-images-release.yml
. In that case, the new integration and cypress test images are created in Quay under the released tag version, e.g.1.65.12
. Also, the images under the tag1.65
are updated to point to the latest Z version (other words, the X.Y tag will contain always the latest X.Y.Z released version).Issue reference
Ref:
https://issues.redhat.com/browse/OSSM-5306
https://issues.redhat.com/browse/OSSM-5307
https://issues.redhat.com/browse/OSSM-5356
Examples
v1.65.30
,v1.65.31
andv1.65.32
. So after that, the Quay repo containsv1.65.30
,v1.65.31
,v1.65.32
andv1.65
[same as v1.65.32] imagesAdditional info
I will backport this to the master and other necessary branches[which are maintained]. This needs to be backported as well (+ update cypress docker file), that is why firstly I want to add all these changes to 1.65 which is ready for it.