Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for health check, use prom healthy endpoint by default #6969

Merged
merged 1 commit into from Dec 18, 2023

Conversation

jmazzitelli
Copy link
Collaborator

fixes: #6966

@jmazzitelli
Copy link
Collaborator Author

to test, just deploy everything normally and get into a good state. Then scale down the prometheus deployment to 0 pods:

kubectl scale --replicas=0 deployment -n istio-system prometheus

and then look at the Kiali UI and wait for it to refresh. You should get the "unreachable" masthead message (along with some other bad errors because prometheus is down, but ignore those, that's not part of this issue).

Then scale up the prom deployment back to 1:

kubectl scale --replicas=1 deployment -n istio-system prometheus

and the Kiali UI should go back to normal - you should no longer see the "unreachable" masthead message.

@jshaughn jshaughn self-requested a review December 18, 2023 18:14
Copy link
Collaborator

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the test instructions successfully. LG

@jmazzitelli jmazzitelli merged commit e701a95 into kiali:master Dec 18, 2023
7 checks passed
@jmazzitelli jmazzitelli deleted the 6966-prom-healthy branch December 18, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

use the Prometheus /-/healthy endpoint for the default value for health_check_url
2 participants