Upgrade Patternfly to version 5.2.0 #7099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshaughn
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Upgrade Patternfly to version 5.2.0
Issues found when upgrading:
There was some typescript issue in
ChartWithLegendcomponent due to typescript migration ofvictory-create-containerpackage (https://www.github.com/FormidableLabs/victory/pull/2731). I have fixed it refactoring the container part of this. component.Following error message appeared on chart loading:
It has been fixed adding
yvalue to scale like it is commented here: https://www.github.com/FormidableLabs/victory/issues/2489Recent change in
victorylibrary (version 36.9.0) makesreact-chartsto throw an error (https://www.github.com/patternfly/patternfly-react/issues/10064). I have fixed it modifyingvictorydependency version inresolutionssection of package.json (from version ^36.8.1 to version ~36.8.1). This workaround should be removed in the next upgrade of Patternfly.Steps to test the PR
Perform some smoke test to check that Kiali works as expected
Automation testing
Not needed.
Issue reference
Closes #7089