Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifying Kiali Client methods to use getRequestAndUnmarshalInto to avoid masking of errors returned by the server #7215

Merged
merged 9 commits into from Apr 1, 2024
Merged

Modifying Kiali Client methods to use getRequestAndUnmarshalInto to avoid masking of errors returned by the server #7215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f43696f
Modifying Kiali Client methods to use
PrinsonF77 Mar 21, 2024
69f7682
Revert ObjectDashboard as it ignores unmarshall
PrinsonF77 Mar 21, 2024
bccfed7
Revert NamespaceWorkloadHealth, NamespaceAppHealth and NamespaceServi…
PrinsonF77 Mar 21, 2024
02c8c06
Revert PodLogs method
PrinsonF77 Mar 21, 2024
356fff5
Merge branch 'master' into master
PrinsonF77 Mar 25, 2024
6118f8b
Updated Namespace and PodLogs methods to use getRequestandUnmarshalInto
PrinsonF77 Mar 27, 2024
84fe867
Fixed TestInvalidNamespaceHealth
PrinsonF77 Mar 27, 2024
dc4e618
Fixed TestNamespaceHealthInvalidRate
PrinsonF77 Mar 27, 2024
02c44a7
Revert PodLogs method and fixed TestNamespaceHealthInvalidRate
PrinsonF77 Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/integration/tests/namespaces_test.go
View file
Open in desktop
Expand Up @@ -41,7 +41,8 @@ func TestInvalidNamespaceHealth(t *testing.T) {
_, code, err := kiali.NamespaceWorkloadHealth("invalid", params)

// namespace not found instead of internal server error
require.Nil(err)
require.Error(err)
require.Contains(err.Error(), "namespaces \\\"invalid\\\" not found")
require.NotEqual(200, code)
}

Expand Down Expand Up @@ -70,7 +71,8 @@ func TestNamespaceHealthInvalidRate(t *testing.T) {
_, code, err := kiali.NamespaceAppHealth(kiali.BOOKINFO, params)

// 500 and error message which is not failing in unmarshalling
require.Nil(err)
require.Error(err)
require.Contains(err.Error(), "not a valid duration string: \\\"invalid\\\"")
require.NotEqual(200, code)
}

Expand Down