Service list backend request per cluster #7229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhovsepy
force-pushed
the
issue4832_services
branch
2 times, most recently
from
543cda2
to
3d22ef8
Compare
hhovsepy
added
the
test: back-end/integration
hhovsepy
force-pushed
the
issue4832_services
branch
from
079ba5f
to
f089557
Compare
|
Ready for review @nrfox |
|
@nrfox this PR is rebased and ready for review. |
ferhoyos
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
One more great optimization, @hhovsepy!
In my environment with 200 namespaces:
- Previously, loading the service list required 200 requests, which took around 600 ms:
- Now, it is simplified to just 1 request, which takes 180 ms:
As a nice to have, in case the user has numerous services and namespaces, I think it would be better to initially display a Loading services message instead of No services found. Despite the optimization, if the request takes a couple of seconds, the user can think there is an issue with Kiali.
|
Thanks for the review @ferhoyos , that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
In Service list page, there was sending a REST API request to retrieve services per namespace, which was causing to filter per cluster which contains the provided namespace.
Now Optimized to send Service list request to REST API per cluster with providing selected namespaces list.
Steps to test the PR
Create a set of namespaces:
for i in {1..200}; do kubectl create ns test-$i; doneOpen the Service list page and select all services.
Compare the loading time between before and now.
Check if Health and Configuration fields are loading correctly: There was a bug here which was mirroring one cluster's Configuration to another one when two Services with same name/namespace.
Automation testing
Added unit tests. Added integration tests.
Issue reference
#4832