Update Content-Type for login request #7253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrfox
reviewed
Apr 4, 2024
Comment on lines
+105
to
+106
| const getHeaders = (urlEncoded?: boolean): Partial<AxiosHeaders> => { | ||
| if (apiProxy || urlEncoded) { |
There was a problem hiding this comment.
It looks like this leaves off ...loginHeaders. Should those be included for both content types?
There was a problem hiding this comment.
I've thought that loginHeaders contain the login information (Once logged in), but let me verify
There was a problem hiding this comment.
I'm wondering if OSSMC should also have those login headers? @ferhoyos?
There was a problem hiding this comment.
I don't think so, as OSSMC leverages of Openshift login. Where loginHeaders 'X-Auth-Type-Kiali-UI': '1' is used?
Said that, including loginHeaders probably do not affect OSSMC. Maybe you can simplify the code:
if (apiProxy || urlEncoded) {
return { 'Content-Type': 'application/x-www-form-urlencoded', ...loginHeaders };
} else {
return { 'Content-Type': 'application/json', ...loginHeaders };
}
josunect
added
backport needed
nrfox
previously approved these changes
Apr 4, 2024
josunect
changed the title
nrfox
approved these changes
Apr 4, 2024
josunect
added a commit
to josunect/kiali
that referenced
this pull request
Apr 5, 2024
* Update encoding for login requests
josunect
added a commit
that referenced
this pull request
Apr 5, 2024
jshaughn
added
test: front-end/cypress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7252