Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed validations for details, load configs for all namespaces #7296

Merged
merged 2 commits into from Apr 24, 2024

Conversation

hhovsepy
Copy link
Contributor

@hhovsepy hhovsepy commented Apr 23, 2024

Describe the change

There was a regression in Istio config details validations that only local namespace objects are loaded, now it loads config objects for all namespaces.

Steps to test the PR

  1. Create a gateway
  2. Create a virtual service in a different namespace and map it that gateway

Automation testing

Added unit and cypress tests.

Issue reference

#7287

@hhovsepy hhovsepy added test: front-end/cypress PR adds/updates front-end tests (unit and/or cypress automation ) test: back-end/integration PR adds/updates back-end tests (unit and/or integration) labels Apr 23, 2024
@hhovsepy hhovsepy self-assigned this Apr 23, 2024
@hhovsepy hhovsepy marked this pull request as ready for review April 23, 2024 13:50
@hhovsepy hhovsepy requested review from nrfox and josunect April 23, 2024 13:50
Copy link
Contributor

@josunect josunect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

Tested and work as expected:

image

@hhovsepy hhovsepy merged commit ce40189 into kiali:master Apr 24, 2024
9 checks passed
@hhovsepy hhovsepy added the backport needed Issue PRs require backport to versions specified in comments label Apr 24, 2024
hhovsepy added a commit to hhovsepy/kiali that referenced this pull request Apr 24, 2024
…#7296)

* Fixed validations for details, load configs for all namespaces, added tests.

* fixed test
hhovsepy added a commit that referenced this pull request Apr 24, 2024
#7296) (#7304)

* Fixed validations for details, load configs for all namespaces (#7296)

* Fixed validations for details, load configs for all namespaces, added tests.

* fixed test

* Update helm chart values for otel (#7291)

* Update helm chart values for otel

* Use contrib repo

---------

Co-authored-by: Josune Cordoba <49480155+josunect@users.noreply.github.com>
@jshaughn jshaughn removed the backport needed Issue PRs require backport to versions specified in comments label May 4, 2024
@jshaughn jshaughn mentioned this pull request May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test: back-end/integration PR adds/updates back-end tests (unit and/or integration) test: front-end/cypress PR adds/updates front-end tests (unit and/or cypress automation )
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants