Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8sGRPCRoute updated to released v1 #7360

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

hhovsepy
Copy link
Contributor

@hhovsepy hhovsepy commented May 16, 2024

Describe the change

Explanation of what this PR does
K8sGRPCRoute is updated to v1 which comes with K8s GW API v1.1.0 CRDs.

Steps to test the PR

  • Apply K8s GW CRDs v1.1.0. kubectl apply -k "github.com/kubernetes-sigs/gateway-api/config/crd/experimental?ref=v1.1.0"
  • Create GRPCRoute v1alpha2:
apiVersion: gateway.networking.k8s.io/v1alpha2
kind: GRPCRoute
metadata:
  name: example-route
spec:
  parentRefs:
  - name: example-gateway
  hostnames:
  - "example.com"
  rules:
  - backendRefs:
    - name: example-svc
      port: 50051
  • Load Kiali. Make sure that GRPCRoute created loading fine in Kiali Istio Config YAML editor. It should change it to v1.
  • Update/View/Delete the GRPCRoute, it should work fine.

Automation testing

Existing cypress and e2e tests are updated to support v1 in v1.1.0.

Issue reference

#7355

Blocked by #7359

@hhovsepy hhovsepy self-assigned this May 16, 2024
@hhovsepy hhovsepy marked this pull request as ready for review May 16, 2024 19:36
Copy link
Contributor

@ferhoyos ferhoyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I view the GRPCRoute example and I am able to update and delete it.

image

Copy link
Collaborator

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems, looks good to me!

@jshaughn jshaughn added the test: n/a PR does not need test additions or updates label May 22, 2024
@jshaughn
Copy link
Collaborator

Merging as the CI issue is a known flake.

@jshaughn jshaughn merged commit 6b04b6c into kiali:master May 22, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test: n/a PR does not need test additions or updates
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants