Initial load graph or mesh on componentDidMount #7368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshaughn
previously approved these changes
May 21, 2024
|
Yes, it is a very useful trick to have in your UI development toolset :-) |
ferhoyos
force-pushed
the
308-initial-load-mesh
branch
from
53bab1c
to
2ebf2c6
Compare
ferhoyos
force-pushed
the
308-initial-load-mesh
branch
from
2ebf2c6
to
9e9ff4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
The initial loading of the mesh and graph data is performed in the
componentDidUpdatemethod to ensure that everything is set before the mesh loads. The issue is that thecomponentDidUpdatemethod is not called in OSSMC during the initial mesh load, so the page displays theLoadingmessage until the user performs an action that triggers the componentDidUpdate method.This PR also sets some missing redux properties in the mesh page and fix lint issues.
Steps to test the PR
This PR only affects OSSMC. Kiali standalone should work as usual.
Automation testing
N/A
Issue reference
kiali/openshift-servicemesh-plugin#308